backup-list-instance cmd doesn't validate instance id

[Doug Shelley]

trove backup-list bogus-instance-id returns:
+----+------+--------+-----------+---------+
| id | name | status | parent_id | updated |
+----+------+--------+-----------+---------+
+----+------+--------+-----------+---------+

I believe it should return something like this:
ERROR: No instance with an ID of 'bogus-instance-id' exists.

[Denis M. (dmakogon)]

Actually it doesn't look like a bug. API did what you've asked - filtered backups by instance id that doesn't exist. But i do agree, that we need to raise HTTP 404 Not Found for cases like this.

I've noticed that we didn't filtering by instance ID at all,
see https://github.com/openstack/python-troveclient/blob/master/troveclient/v1/backups.py#L41-L51
and see https://github.com/openstack/trove/blob/master/trove/backup/service.py#L35-L46

[Denis M. (dmakogon)]

I'm marking this bug-report as invalid due to previous comments. API did what was asked for. Under the Troves hood this isn't a bug, since backend API doesn't raise ModelNotFound when trying to filter list of backups by bogus instance ID.

[Amrith Kumar (amrith)]

That doesn't make it invalid, necessarily. What the person reporting the bug is saying is that something under the "Troves hood" is not doing the right thing (in his/her opinion).

I submit to you that it is your (Denis') opinion that this isn't a bug.

[Amrith Kumar (amrith)]

Doug, please update with new information if you believe this is still an issue (else please close this). Thanks!

[dangming (743759846-7)]

You can use command "trove backup-list-instance",it will return Error if instance_id is not exist

[Fan Zhang (fanzhang)]

I do agree with Denis, command 'trove backup-list-instance' actually did what was asked.

[root@node-141 ~](controller)# trove backup-list-instance xxxxx
+----+------+--------+-----------+---------+
| ID | Name | Status | Parent ID | Updated |
+----+------+--------+-----------+---------+
+----+------+--------+-----------+---------+

It looks fine to me. I suggest closing this bug.