test_versions.py is currently breaking pep8 in master

Bug #1363019 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Dolph Mathews

Bug Description

Somehow a set of bad aligned '}' has got into master in test_versions.py, which is causing every patch to fail. This fixes it.

Henry Nash (henry-nash)
Changed in keystone:
importance: Undecided → Critical
assignee: nobody → Henry Nash (henry-nash)
milestone: none → juno-3
Changed in keystone:
status: New → In Progress
Revision history for this message
Henry Nash (henry-nash) wrote :

So it seems that there is a formatting issue, but it is more subtle that it fails in some (maybe older?) versions of flake, but no long the one being run by Jenkins. Should still try and fix it so it passes in all cases.

Changed in keystone:
importance: Critical → Medium
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Henry,

do you have some logs where this is happening?

tags: added: test-improvement
Revision history for this message
Lance Bragstad (lbragstad) wrote :

tried recreating this pep8 1.5.0+ and flake8 1.7.0+ and wasn't able to recreate

Revision history for this message
Henry Nash (henry-nash) wrote :

Here's what I get:

./keystone/tests/test_versions.py:320:5: E123 closing bracket does not match indentation of opening bracket's line
    }),
    ^
./keystone/tests/test_versions.py:331:5: E123 closing bracket does not match indentation of opening bracket's line
    }),
    ^
./keystone/tests/test_versions.py:341:5: E123 closing bracket does not match indentation of opening bracket's line
    }),
    ^
./keystone/tests/test_versions.py:351:5: E123 closing bracket does not match indentation of opening bracket's line
    }),
    ^

Dolph Mathews (dolph)
Changed in keystone:
milestone: juno-3 → none
status: In Progress → Incomplete
status: Incomplete → Triaged
milestone: none → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118894

Changed in keystone:
assignee: Henry Nash (henry-nash) → Dolph Mathews (dolph)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/118894
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5157bc62bf3b7aa3792f8148c42bc7213b607068
Submitter: Jenkins
Branch: master

commit 5157bc62bf3b7aa3792f8148c42bc7213b607068
Author: Dolph Mathews <email address hidden>
Date: Wed Sep 3 15:53:20 2014 -0500

    use one indentation style

    There are two (or three, depending on how you count) indentations styles
    mixed together in this one logical line of code, which are further mixed
    with two methods of closing parens and curly braces.

    Besides being difficult to read, the mixture resulted in an off-by-one
    error that isn't caught by the version of hacking that Jenkins is using,
    but is caught by the latest.

    Change-Id: Idab3c80c720e0bfd5741dc9e07f841b5ac270960
    Closes-Bug: 1363019

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Dolph Mathews (<email address hidden>) on branch: master
Review: https://review.openstack.org/117732
Reason: fixed in https://review.openstack.org/#/c/118894/

Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.