puppet-nova calls nova-manage with --vlan when it means --vlan_start

[Lars Kellogg-Stedman]

In lib/puppet/provider/nova_network/nova_manage.rb, puppet-nova is using --vlan when it means --vlan_start. This results in a command line such as:

  nova-manage network create novanetwork 192.168.32.0/21 6 --vlan 10

And this will fail, because it will attempt to create multiple networks with vlan id 10.

[Lars Kellogg-Stedman (larsks)]

Fix proposed in:

https://review.openstack.org/#/c/117592/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/117592
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=c40e67f1b5cd59a1755d451e00578404fd5d4c61
Submitter: Jenkins
Branch: master

commit c40e67f1b5cd59a1755d451e00578404fd5d4c61
Author: Lars Kellogg-Stedman <email address hidden>
Date: Thu Aug 28 15:03:01 2014 -0400

    --vlan is not the same as --vlan_start

    the lib/puppet/provider/nova_network/nova_manage.rb provider was using
    the --vlan option when it meant --vlan_start. This caused "network
    create" commands with num_networks > 1 to fail with "duplicate vlan"
    errors.

    Change-Id: Ibdca3b8de72b459eacf8b44b6350b9bc71310c1b
    Closes-bug: #1362772

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/156974

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/156974
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=3d6565d2688042b02ede2a6f7b4db86230e35a55
Submitter: Jenkins
Branch: stable/icehouse

commit 3d6565d2688042b02ede2a6f7b4db86230e35a55
Author: Lars Kellogg-Stedman <email address hidden>
Date: Thu Aug 28 15:03:01 2014 -0400

    --vlan is not the same as --vlan_start

    the lib/puppet/provider/nova_network/nova_manage.rb provider was using
    the --vlan option when it meant --vlan_start. This caused "network
    create" commands with num_networks > 1 to fail with "duplicate vlan"
    errors.

    Change-Id: Ibdca3b8de72b459eacf8b44b6350b9bc71310c1b
    Closes-bug: #1362772
    (cherry picked from commit c40e67f1b5cd59a1755d451e00578404fd5d4c61)