No error message when using duplicate barcodes with Replace Barcode in Holdings Maintenance interface

[Jennifer Pringle]

Master

It is still possible to use an existing item barcode for a serial item if you do the following:

1. Find the item in the catalogue
2. Actions for this Record -> Holdings Maintenance
3. Select the item and click on Actions for Selected Rows -> Replace Barcode
4. Enter duplicate barcode and click Re-barcode / Update Items. Item is saved with duplicate barcode without any warning or error message.

Attempting use a duplicate barcode here should fail with the same errror message "Another copy has barcode "XXXXXXXX", defaulting to system-generated." as seen in:
- Serial Control View -> Items -> Receive/Move Selected
- Serials Batch Receive
- Item Status -> Actions for Cataloguers -> Replace Barcode
- Item Status -> Actions for Selected Items -> Replace Barcode

[Jennifer Pringle (jpringle-u)]

This bug is related to https://bugs.launchpad.net/evergreen/+bug/1081551

[Kathy Lussier (klussier)]

Confirming the bug with the following added information. The barcode is replaced without error in the following cases:

1 - When you replace a barcode for a serials item with a barcode already used on a non-serials item.

or

2 - When you replace a barcode for a non-serials item with a barcode already used on a serials item.

If you try to replace a serials barcode with a barcode already used on a serials item, you do receive an error and the record doesn't save. It's an ugly error that doesn't really inform the user of what happened, but it does stop the system from storing the duplicate barcode.

[Andrea Neiman (aneiman)]

It seems that this still happens in 3.x web client, both as outlined in Jennifer's original post as well as Kathy's comment.

[Mike Risher (mrisher)]

I addressed the issue with the replace barcode feature in the holdings maintenance grid. Duplicate barcodes are now not allowed. Branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1362743-holdings-view-dup-barcode

Unfortunately I'm not understanding how to address comment #2. The main problem I'm running into is never having worked with serials. I'm not yet familiar with Serial items vs. non-serial items. I've looked at documentation, but so far I'm not understanding all the pieces. Could I get step-by-step instructions on how to replicate the problem being reported? Thanks!

[Andrea Neiman (aneiman)]

Did a little testing on 3.4.1 (not including Mike's branch) and I am unable to reproduce Kathy's scenario #1 on comment #2. If I try to replace a serial barcode with a barcode currently in use by a non-serials item, the issuance fails to save. (no indication as to WHY, but that's a separate bug. I do get a "failed to save" toast in the lower right.)

However, I do still see Kathy's scenario #2 - I can replace a non-serials item barcode with an in-use serials barcode and it will save without error, but ONLY when I'm using the "Replace Barcodes" function from Holdings Maintenance, as Jennifer noted in the original report. If I try to create a new non-serials item (or edit the barcode from within Item Edit), I get the expected duplicate barcode alert even when using an in-use serials barcode.

I am NOT able to use "Replace Barcodes" to replace a barcode with an in-use NON-serials barcode. I don't get any error message (but lots of ugly console noise) but it does fail to save.

[Mike Risher (mrisher)]

I went back and tested my work on the "Replace Barcodes" function on the holdings maintenance grid. It is successfully prevent duplicate barcodes in all the scenarios described above. It's ready for review, so I'm adding a pull request tag.

[Elaine Hardy (ehardy)]

We tested this on the PINES test server and it does display the duplicate barcode message when either using replace barcode from actions for this record or if editing the barcode using edit items. (One of our acq libraries discovered that the message didn't display when in edit items and call numbers.

Workflow acq library uses:

From Holdings view -- actions for this record --- edit call numbers and items

We haven't implemented serials so I can't test that.

However, there is another place for replacing barcodes that the duplicate barcode message doesn't display--

Circulation menu -- replace barcode.

When attempting to replace the barcode here, no error message is displayed and submit fails silently.

I can do another bug report on this if you prefer.

[Mike Risher (mrisher)]

Thank you for reporting this, Elaine Hardy. I confirmed the problem and created a new bug for it. See bug #1890498

I already have an idea how to fix it and I'll be pushing a fix shortly.

[Elaine Hardy (ehardy)]

Thanks, Mike! I will see if we can get it tested as well.

[Jennifer Weston (jweston)]

Tested "Replace Barcodes" function. It successfully prevents duplicate barcodes in all the scenarios described above with the following exceptions as reported in separate bugs:
Bug #1890498 (reported by Elaine)
Bug #1891961 (I added today for one specific serial vs non-serial instance)

I'm signing off on this one as it fixes previously reported duplicate barcode issues. New issues discovered are on new bugs.

I have tested this code and consent to signing off on it with my name, jweston, <email address hidden>

[Jason Etheridge (phasefx)]

Jennifer, I meant to add your sign off to the actual commit but neglected to. Nonetheless, it's in master now. Thanks Mike, everyone!

[Jason Etheridge (phasefx)]

This has also been pushed to rel_3_5 and rel_3_4