Volume Type Extra Specs needs modal dialog

[Richard Hagarty]

Currently, when a user wants to create an Extra Spec, the panel changes to show 2 input fields - "key" and "value".

This deviates from other "like" Horizon panels where the new fields are presented in a modal dialog.

Actually, I think this is what was intended because if you look at the code in volume_types/extras/tables.py:ExtraSpecCreate(), the class it specifies is "ajax-modal".

But a trailing "," was left off, invalidating the call. Simply adding a trailing comma to this call will result in a modal dialog being displayed.

[Richard Hagarty (richard-hagarty)]

Suggestion - change:

classes = ("ajax-modal")

to:

classes = ("ajax-modal",)

[Julie Gravel (julie-gravel)]

Added screen capture of the dialog. Notice that there's no highlighting of the first field where the cursor should be.

[Zhenguo Niu (niu-zglinux)]

This bug was introduced by adding 'Create' buttons missing '+' icon: https://review.openstack.org/#/c/110167/

and can you please also fix the same issue at Image Custom Properties-> class PropertyCreate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118463

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118477

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julie Gravel (<email address hidden>) on branch: master
Review: https://review.openstack.org/118463
Reason: The new submit for this is https://review.openstack.org/#/c/118477.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118477
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9fa131cfeb1311ac9284d906602140582cf2acaf
Submitter: Jenkins
Branch: master

commit 9fa131cfeb1311ac9284d906602140582cf2acaf
Author: Julie Gravel <email address hidden>
Date: Tue Sep 2 02:58:12 2014 -0700

    Fix missing trailing commas for modal dialogs

    Trailing commas were accidentally removed from the 'classes' attribute
    of the table actions for the Create Property and the Create Volume Type
    Extra Spec dialogs. This caused the dialogs to lose the modality.

    This submit fixes the problem on the two dialogs.

    Change-Id: Id2c2d1f8354e95016dc121d1143a6ea5b4460de1
    Closes-Bug: #1362704