'Force' option broken for quota update

Bug #1362405 reported by Kieran Spear
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Kieran Spear

Bug Description

This change broke the ability to force quotas below the current in-use value by adding new validation checks:

https://review.openstack.org/#/c/28232/

$ nova quota-update --force --cores 0 132
ERROR (BadRequest): Quota limit must be greater than 1. (HTTP 400) (Request-ID: req-ff0751a9-9e87-443e-9965-a30768f91d9f)

Tags: api
Kieran Spear (kspear)
Changed in nova:
assignee: nobody → Kieran Spear (kspear)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117438

Changed in nova:
status: New → In Progress
Alex Xu (xuhj)
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/117438
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bf5d003af694ea1eb95fceea8c36e961092cb516
Submitter: Jenkins
Branch: master

commit bf5d003af694ea1eb95fceea8c36e961092cb516
Author: Kieran Spear <email address hidden>
Date: Tue Sep 9 15:32:13 2014 +1000

    Fix 'force' parameter for quota-update

    Commit 77b4012a02c6b4827a7a6b112f35deb9ce94c395 added further
    validation on the quota update controller that isn't aware of the
    'force' parameter. This validation also duplicated the existing
    validation that *did* honour 'force'.

    This change merges the two validation methods and ensures that the
    validation is skipped when the 'force' parameter is passed in the
    request.

    Change-Id: I25e3ce857a83cb50789a2a61bb01c796128ff4f8
    Closes-bug: #1362405

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.