Missing attempt to import necessary module for some drivers in ironic/drivers/fake.py

Bug #1362114 reported by Sergey Lupersolsky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Sergey Lupersolsky

Bug Description

In https://github.com/openstack/ironic/blob/master/ironic/drivers/fake.py#L86, there needs to be code to try to import 'pyghmi something' similar to what is done in FakeSeaMicroDriver.

Also FakeIBootDriver needs to be fixed.

Changed in ironic:
assignee: nobody → Sergey Lupersolsky (slupers1)
description: updated
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121715

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/121715
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=70792910abac2bcf8e34113e496a76f47482538d
Submitter: Jenkins
Branch: master

commit 70792910abac2bcf8e34113e496a76f47482538d
Author: Sergey Lupersolsky <email address hidden>
Date: Mon Sep 15 23:20:49 2014 +0000

    Import modules for fake IPMINative/iBoot drivers

    The fake IPMINative and iBoot drivers are not attempting to import the
    necessary Python modules for proper operation.
    To fix the issue, this patch attempts to import 'pyghmi' for the fake
    IPMINative driver and 'iboot' for the fake iBoot driver. If the module
    that is attempted to be imported is not available, then a
    DriverLoadError is raised.

    Change-Id: I5085a45c867c339ef900d89b5c830467398b3db1
    Closes-Bug: 1362114

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.