HA deployment failed err: invalid address (fuel_settings['nodes'][0]['public_netmask'])

[Dennis Dmitriev]

Custom ISO deployment failed because of network configuration error:

Job: http://jenkins-product.srt.mirantis.net:8080/view/custom_iso/job/custom.centos.bvt_1/50/
Parent bug: https://bugs.launchpad.net/fuel/+bug/1272349

================ Puppet error on node-3:
2014-08-26T11:14:25.749401+01:00 err: invalid address at /etc/puppet/modules/osnailyfacter/manifests/cluster_ha.pp:139 on node node-3.test.domain.local
2014-08-26T11:14:25.749401+01:00 err: /usr/lib/ruby/1.8/ipaddr.rb:467:in `initialize'
2014-08-26T11:14:25.749459+01:00 err: /etc/puppet/modules/l23network/lib/puppet/parser/functions/netmask_to_cidr.rb:16:in `new'
2014-08-26T11:14:25.749459+01:00 err: /etc/puppet/modules/l23network/lib/puppet/parser/functions/netmask_to_cidr.rb:16:in `real_function_netmask_to_cidr'
2014-08-26T11:14:25.749544+01:00 err: /usr/lib/ruby/site_ruby/1.8/puppet/parser/functions.rb:144:in `send'
2014-08-26T11:14:25.749594+01:00 err: /usr/lib/ruby/site_ruby/1.8/puppet/parser/functions.rb:144:in `function_netmask_to_cidr'
2014-08-26T11:14:25.749681+01:00 err: /usr/lib/ruby/site_ruby/1.8/puppet/util/profiler/none.rb:6:in `profile'
2014-08-26T11:14:25.749738+01:00 err: /usr/lib/ruby/site_ruby/1.8/puppet/util/profiler.rb:31:in `profile'

================ Puppet manifest with testing patch in /etc/puppet/modules/osnailyfacter/manifests/cluster_ha.pp :
   if $::public_int {
    $vips[public_old] = {
      namespace => 'haproxy',
      nic => $::public_int,
      base_veth => "${::public_int}-hapr",
      ns_veth => "hapr-p",
      ip => $::fuel_settings['public_vip'],

# Line №139:
      cidr_netmask => netmask_to_cidr($::fuel_settings['nodes'][0]['public_netmask']),

      gateway => 'link',
      gateway_metric => '10',
      iptables_start_rules => "iptables -t mangle -I PREROUTING -i ${::public_int}-hapr -j MARK --set-mark 0x2a ; iptables -t nat -I POSTROUTING -m mark --m
      iptables_stop_rules => "iptables -t mangle -D PREROUTING -i ${::public_int}-hapr -j MARK --set-mark 0x2a ; iptables -t nat -D POSTROUTING -m mark --m
      iptables_comment => "masquerade-for-public-net",
    }

================ Data passed to node-3 by nailgun:
 "nodes": [
                 ...
                        {
                            "swift_zone": "3",
                            "uid": "3",
                            "public_address": "10.108.11.3",
                            "internal_netmask": "255.255.255.0",
                            "fqdn": "node-3.test.domain.local",
                            "role": "primary-controller",
                            "public_netmask": "255.255.255.0",
                            "internal_address": "10.108.12.5",
                            "storage_address": "10.108.14.4",
                            "storage_netmask": "255.255.255.0",
                            "name": "node-3"
                        },

================

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114198
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=336d3811e8cf941a1b969d19335b9654af7a4d7c
Submitter: Jenkins
Branch: master

commit 336d3811e8cf941a1b969d19335b9654af7a4d7c
Author: Sergey Vasilenko <email address hidden>
Date: Thu Aug 14 14:42:33 2014 +0400

    make public interface (br-ex) non-obligatory

    Partial-bug: #1272349
    Closes-bug: #1361707

    Change-Id: I41b67fe56f03e931ae8e4bc627799468bcc48ef7