juju ignores environments.yaml on failed bootstrap if $PROVIDER.jenv exists

[Adam Stokes]

The issue I find a little weird/inconvenient is I have a openstack configuration defined in environments.yaml. Lets say I put in a wrong ip address for `auth-url` and attempt to `juju bootstrap`. It'll fail as expected, however, it will create a `~/.juju/envirornments/openstack.jenv`.

This contains the incorrect auth-url and any updates to `environments.yaml` will be ignored. I don't know the justification behind this but this seems a little weird to me that a broken `openstack.jenv` takes precedence over my `environments.yaml` even though juju never actually bootstraps.

This is on juju 1.20.5 (seen as early as 1.20.0) Ubuntu Trusty 14.04

[Katherine Cox-Buday (cox-katherine-e)]

Because we don't ever want to destroy a user's jenv file, we've decided to not try and generate a new one; however, we should now correctly handle the case where the environments.yaml file was bad to begin with and clean up any bad jenv files seeded from this environments.yaml file. That should at least prevent us from getting into this state in the use case you've outlined.

The code has been modified and we're currently waiting on a blocking issue to land it.