recoverable problem crash files created which whoopsie cannot read

[Brian Murray]

I've seen it happen that recoverable problems are created that whoopsie has no permission to read and subsequently cannot upload the crash file to the error tracker.

root@ubuntu-phablet:~# ls -lh /var/crash/
total 380K
-rw-r----- 1 phablet whoopsie 262K Aug 25 14:20 _usr_bin_mtp-server.32011.crash
-rw-r--r-- 1 phablet nopasswdlogin 0 Aug 25 14:20 _usr_bin_mtp-server.32011.upload
-rw------- 1 whoopsie nopasswdlogin 0 Aug 25 14:20 _usr_bin_mtp-server.32011.uploaded
-rw-r----- 1 phablet nopasswdlogin 93K Aug 25 15:00 _usr_share_click_preinstalled_com.ubuntu.filemanager_0.3.260_lib_arm-linux-gnueabihf_bin_filemanager.32011.crash
-rw-r--r-- 1 phablet nopasswdlogin 0 Aug 25 15:00 _usr_share_click_preinstalled_com.ubuntu.filemanager_0.3.260_lib_arm-linux-gnueabihf_bin_filemanager.32011.upload
-rw------- 1 whoopsie nopasswdlogin 0 Aug 25 15:00 _usr_share_click_preinstalled_com.ubuntu.filemanager_0.3.260_lib_arm-linux-gnueabihf_bin_filemanager.32011.uploaded

And in /var/log/upstart/whoopsie.log we see:

Parsing /var/crash/_usr_share_click_preinstalled_com.ubuntu.filemanager_0.3.260_
lib_arm-linux-gnueabihf_bin_filemanager.32011.crash.^M
^M
(whoopsie:2309): GLib-CRITICAL **: g_mapped_file_unref: assertion 'file != NULL'
 failed^M
Unable to parse report (/var/crash/_usr_share_click_preinstalled_com.ubuntu.file
manager_0.3.260_lib_arm-linux-gnueabihf_bin_filemanager.32011.crash): Unable to
map report: Failed to open file '/var/crash/_usr_share_click_preinstalled_com.ub
untu.filemanager_0.3.260_lib_arm-linux-gnueabihf_bin_filemanager.32011.crash': o
pen() failed: Permission denied^M

[Brian Murray (brian-murray)]

This is reproducable by clicking on any image in the File Manager.

root@ubuntu-phablet:~# system-image-cli -i
current build number: 207
device name: mako
channel: ubuntu-touch/utopic-proposed
last update: 2014-08-25 10:38:50
version version: 207
version ubuntu: 20140825
version device: 20140811.1

[Brian Murray (brian-murray)]

Fixing this (the permissions of the .crash file) in the apport code for recoverable_problem is not possible given who recoverable_problem is running as.

I tried having recoverable_problem use os.chown(report_path, pidstat.st_uid, gid) and this ended up creating a crash in recoverable_problem.

Traceback:
 Traceback (most recent call last):
   File "/usr/share/apport/recoverable_problem", line 85, in <module>
     main()
   File "/usr/share/apport/recoverable_problem", line 77, in main
     os.chown(report_path, pidstat.st_uid, gid)
 OSError: [Errno 1] Operation not permitted: '/var/crash/_usr_share_click_preins
talled_com.ubuntu.filemanager_0.3.260_lib_arm-linux-gnueabihf_bin_filemanager.32
011.crash'

[Brian Murray (brian-murray)]

I also tried to change the owner in whoopsie-upload-all and that created the same traceback.

[Brian Murray (brian-murray)]

I've reinstalled my phone and recoverable problems are now owned by whoopsie.

root@ubuntu-phablet:~# ls -lh /var/crash/
total 112K
-rw-r----- 1 phablet whoopsie 17K Aug 26 18:07 _usr_lib_arm-linux-gnueabihf_url-dispatcher_update-directory.32011.crash
-rw-r--r-- 1 phablet whoopsie 0 Aug 26 18:07 _usr_lib_arm-linux-gnueabihf_url-dispatcher_update-directory.32011.upload
-rw------- 1 whoopsie whoopsie 0 Aug 26 19:18 _usr_lib_arm-linux-gnueabihf_url-dispatcher_update-directory.32011.uploaded
-rw-r--r-- 1 phablet whoopsie 92K Aug 26 18:23 _usr_share_click_preinstalled_com.ubuntu.filemanager_0.3.254_lib_arm-linux-gnueabihf_bin_filemanager.32011.crash

root@ubuntu-phablet:~# system-image-cli -i
current build number: 203
device name: mako
channel: ubuntu-touch/utopic
last update: 2014-08-26 17:34:25
version version: 203
version ubuntu: 20140821.1
version device: 20140811.1