Patron self-registration form accepts date of birth in wrong format
Bug #1361266 reported by
Terran McCanna
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
2.7 |
Fix Released
|
Medium
|
Unassigned | ||
2.8 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
DOB field on patron self-registration form indicates that DOB should be entered in YYYY-MM-DD format, but it will accept it in other formats. When it is accepted in other formats, it appears on the Pending Patrons table, but does not import into the full user registration form.
Ideally, the patron self-registration form would accept DOB in any common format and swap it to the format it needs upon saving the form. It would also be nice to have a date picker/calendar available for patrons to use. At the very least, it should show an error if the date is entered in the wrong format.
Evergreen 2.5.1
OpenSRF 2.2.1
PostgreSQL 9.1.11
Ubuntu 12.04 LTS
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
assignee: | nobody → Josh Stompro (u-launchpad-stompro-org) |
Changed in evergreen: | |
importance: | Undecided → Medium |
Changed in evergreen: | |
milestone: | 2.9-alpha → 2.9-beta |
milestone: | 2.9-beta → 2.next |
milestone: | 2.next → 2.7.7 |
milestone: | 2.7.7 → 2.8.3 |
milestone: | 2.8.3 → 2.9-beta |
Changed in evergreen: | |
milestone: | 2.9-beta → 2.9.0 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Terran,
I've submitted a patch to the working repo at http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ mrpeters/ lp1361266_ opac_registrati on_date_ validation to help alleviate some of the annoyance of not having any validation at all on the field.
This adds some simple JavaScript to make sure the input in the stgu.dob text field is in ISO 8601 format upon submitting. If not, the user receives a warning about an invalid date or format and is asked to correct it.
I know this may not be able to be accepted into Evergreen "master" because the popup message is not i18n friendly, but I'm submitting it anyways as lots of implementations are English-speaking organizations and this can benefit them. Hopefully someone can implement a more i18n friendly solution in the future, or maybe even add that date picker, but I wanted to at least resolve the problem you proposed with a little bit of data format validation.
This should cherry-pick cleanly into any version of Evergreen that supports patron self registration (assuming you have enabled the YAOUS to allow it) and is available from http:// hostname. tld/eg/ opac/register which can be linked from your website or OPAC.