Neutron metering does not check overlapping ip range

Bug #1361264 reported by Liping Mao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Liping Mao

Bug Description

I use neutron metering api to create two same rules, I did not get any error. I think that I should get the error "MeteringLabelRuleOverlaps" defined in neutron/extensions/metering.py

BTW,
We define the following error inherit "NotFound", I think "Conflict" is better:

In neutron/extensions/metering.py

class MeteringLabelRuleOverlaps(qexception.NotFound):
    message = _("Metering label rule with remote_ip_prefix "
                "%(remote_ip_prefix)s overlaps another")

Tags: metering
Liping Mao (limao)
description: updated
summary: - Neutron metering overlap ip range
+ Neutron metering do not overlap ip range
summary: - Neutron metering do not overlap ip range
+ Neutron metering do not check overlap ip range
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116652

Changed in neutron:
assignee: nobody → Liping Mao (limao)
status: New → In Progress
summary: - Neutron metering do not check overlap ip range
+ Neutron metering does not check overlapping ip range
Changed in neutron:
importance: Undecided → Low
tags: added: metering
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/116652
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b0b7b66495a556af939cc62e02b8b60462232172
Submitter: Jenkins
Branch: master

commit b0b7b66495a556af939cc62e02b8b60462232172
Author: Liping Mao <email address hidden>
Date: Mon Aug 25 23:30:21 2014 +0800

    Neutron metering does not check overlap ip range

    Neutron does not return "MeteringLabelRuleOverlaps" error, when the
    remote ip ranges in the meter label rules are overlapped.

    Change-Id: I4c2536a7d38b5f6d311db365c8c108d5367705a7
    Closes-bug: #1361264

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.