boolean and json parameters in heat template do not appear in launch stack form

Bug #1360495 reported by Miguel Grinberg
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Miguel Grinberg

Bug Description

It appears the heat template parser has some issues handling boolean and json parameters. Use the following steps to reproduce my problem:

1. Go to Stacks and click Launch Stack
2. Set Template Source to Direct Input
3. Paste the following template and then click next.

heat_template_version: 2013-05-23
parameters:
  str_param:
    type: string
  bool_param:
    type: boolean

4. Note that the label of the second parameter is "str_param" instead of "bool_param", so both parameters have the same label.
5. Cancel and repeat the test, but now set the type of the second parameter to string:

heat_template_version: 2013-05-23
parameters:
  str_param:
    type: string
  bool_param:
    type: string

6. Note that now the label of the second parameter displays correctly.

The same issue occurs with json parameters.

Tags: heat
description: updated
Changed in horizon:
assignee: nobody → Miguel Grinberg (miguelgrinberg)
description: updated
description: updated
Akihiro Motoki (amotoki)
tags: added: heat
Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

It appears that the boolean parameter (bool_param) has an incorrect label. The form properly checking that the value entered is indeed boolean. This appears to be related to https://bugs.launchpad.net/horizon/+bug/1356011

Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117374

Changed in horizon:
status: Confirmed → In Progress
summary: - boolean parameters in heat template do not appear in launch stack form
+ boolean and json parameters in heat template do not appear in launch
+ stack form
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/117374
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ad9c303504db0b981d7ec7db6ae01e5f602bd2d9
Submitter: Jenkins
Branch: master

commit ad9c303504db0b981d7ec7db6ae01e5f602bd2d9
Author: Miguel Grinberg <email address hidden>
Date: Tue Aug 26 02:52:30 2014 +0000

    display boolean and json parameters in stack launch form

    Horizon fails to render boolean and json parameters properly in the
    stack launch form, instead of rendering these fields it renders a
    duplicate of the previous field.

    Change-Id: Idb2fcf4b52578951fb578138a80529eefc140d1a
    Closes-Bug: 1360495

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.