Object hash test fails to detect changes when serialize_args is used
Bug #1360333 reported by
Dan Smith
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
Dan Smith |
Bug Description
The object hash test will fail to detect method signature changes when something like the serialize_args decorator is used. The test needs to drill down until it finds the remotable level and do the calculation there.
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | juno-rc1 → 2014.2 |
To post a comment you must log in.
This was fixed in:
commit 767c5d65b625a22 4f818bf5f8b5ac8 cd0a35d7e2
Author: Mikhail Durnosvistov <email address hidden>
Date: Mon Aug 11 16:52:10 2014 +0300
Move and generalize decorator serialize_args to nova.objects.base
It would be nice use decorator `serialize_args` as general-use
decorator. Note that this single-purpose decorator was covering
up our ability to drill down to the actual method implementation
for hash calculation in the TestObjectVersions test. This patch
also enhances the decorator to be transparent, and makes the
test able to drill down through multiple layers of decorators
to find the actual implementation.
Co-Authored-By: Dan Smith <email address hidden> b3a863e975b2fb0 ee6fb1dd552
Change-Id: Ie454bffba113d7