Object hash test fails to detect changes when serialize_args is used

Bug #1360333 reported by Dan Smith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Dan Smith

Bug Description

The object hash test will fail to detect method signature changes when something like the serialize_args decorator is used. The test needs to drill down until it finds the remotable level and do the calculation there.

Revision history for this message
Dan Smith (danms) wrote :

This was fixed in:

commit 767c5d65b625a224f818bf5f8b5ac8cd0a35d7e2
Author: Mikhail Durnosvistov <email address hidden>
Date: Mon Aug 11 16:52:10 2014 +0300

    Move and generalize decorator serialize_args to nova.objects.base

    It would be nice use decorator `serialize_args` as general-use
    decorator. Note that this single-purpose decorator was covering
    up our ability to drill down to the actual method implementation
    for hash calculation in the TestObjectVersions test. This patch
    also enhances the decorator to be transparent, and makes the
    test able to drill down through multiple layers of decorators
    to find the actual implementation.

    Co-Authored-By: Dan Smith <email address hidden>
    Change-Id: Ie454bffba113d7b3a863e975b2fb0ee6fb1dd552

Changed in nova:
milestone: none → juno-rc1
status: Confirmed → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.