V2 hypervisors Unit Test tests hypervisors API as non Admin

Bug #1360113 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Ghanshyam Mann

Bug Description

hypervisors API are Admin API and unit tests should test those accordingly. But All the V2 hypervisors Unit tests (https://github.com/openstack/nova/blob/master/nova/tests/api/openstack/compute/contrib/test_hypervisors.py) tests those as a non Admin API.

Issue is in fake_policy.py where V2 hypervisors API is not marked as Admin role unlike V3. https://github.com/openstack/nova/blob/master/nova/tests/fake_policy.py#L221

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116208

Changed in nova:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
status: New → In Progress
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/116208
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cad9e77091dfa896ad59233341e8947eca13f66b
Submitter: Jenkins
Branch: master

commit cad9e77091dfa896ad59233341e8947eca13f66b
Author: Ghanshyam <email address hidden>
Date: Fri Aug 22 18:05:05 2014 +0900

    Fix V2 unit tests to test hypervisor API as admin

    Hypervisors API are Admin API and unit tests should test those accordingly.
    But All the V2 hypervisors Unit tests tests those as a non Admin API

    This patch fix this issue and add more non-admin unit tests

    Change-Id: I5c29828d567e2044786d4bcbff4970219c6e8c5f
    Closes-Bug: #1360113

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.