bind_router fails to log proper error message

[IWAMOTO Toshihiro]

auto_schedule_routers can call bind_router within a transaction. If a DBDuplicateEntry exception happens in bind_router in such a case, the access to chosen_agent.id causes another exception as the outer transaction is already aborted, resulting in a useless debug log.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/116196

[Armando Migliaccio (armando-migliaccio)]

I believe this is another manifestation of bug: #1354072.

Can you confirm please?

[Armando Migliaccio (armando-migliaccio)]

It would be good to see the stacktrace you're seeing and learning the circumstances of when this happens.

[Armando Migliaccio (armando-migliaccio)]

Before marking this as duplicate of bug 1354072, it probably best to get input from the reporter. My bad if I jumped the gun.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/116315

[IWAMOTO Toshihiro (iwamoto)]

If the transaction in auto_schedule_router isn't needed, removing it fixes the problem.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116315
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fa0abeb043c2f66c537e43a8ea7181f648c71d33
Submitter: Jenkins
Branch: master

commit fa0abeb043c2f66c537e43a8ea7181f648c71d33
Author: armando-migliaccio <email address hidden>
Date: Fri Aug 22 08:21:09 2014 -0700

    Fix InvalidRequestError in auto_schedule_routers

    This was discussed in review [1], and was deferred until the time was ripe
    for the appropriate fix. As suggested and reported, auto_schedule_routers
    is too affected by this error.

    This patch takes care of the issue, in a similar way.

    [1] - https://review.openstack.org/#/c/112740/

    Related-bug: #1354072
    Closes-bug: #1360104

    Change-Id: Ie3cb0c31dfa571c694cd38e19f72ff8503815635

[OpenStack Infra (hudson-openstack)]

Change abandoned by IWAMOTO Toshihiro (<email address hidden>) on branch: master
Review: https://review.openstack.org/116196
Reason: a different fix was merged