Identity panels show loading icon when click on it

[Cindy Lu]

When I click on "Identity" in the right navigation, and then click on either Project or User, I get a brief grey backdrop+loading icon before the table shows up. Clicking on any of the other panels doesn't show this. We should be consistent.

I've only see the brief grey backdrop+loading icon when pulling up a modal.

Please see attached image.

[Takashi Sogabe (sogabe)]

I guess following code in ./horizon/static/horizon/js/horizon.accordion_nav.js is the cause of loading:
...
  // panel selection
  $('.nav_accordion > dd > ul > li > a').click(function() {
    horizon.modals.modal_spinner(gettext("Loading"));
  });

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/116178

[David Lyle (david-lyle)]

I don't agree with the direction of this bug. Horizon as constructed now blocks render until all the data is collected from the APIs and the page is sent from the server to the client. When horizon is used in a production environment, where API calls can take on the order of seconds, this causes the user to click a navigation link and see no action other than hopefully an obscure loading icon from the browser. The purpose of the spinner is to indicate, your action requests has been acknowledged and is being processed. The spinner should be visible on all panels (not just Identity) that take any measurable time to load.

If the spinner is actually not showing up for the instances page when necessary, that would be the bug. But I imagine, you are using this in devstack where the load times are minimal and you are only seeing the spinner because keystone APIs are slower to respond.

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/116178
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Dixon Siu (siu-dixon)]

Just found out that k3 behaves exactly the opposite way when comparing to Icehouse.
Icehouse:
  dashboard -> panel (has spinner)
  dashboard -> panel group -> panel (no spinner)

k3:
  dashboard -> panel (no spinner)
  dashboard -> panel group -> panel (has spinner)

Can someone fix it consistently for all panels?

[Dixon Siu (siu-dixon)]

Suggestion 1:
  // panel selection
  $('.nav_accordion > dd > ul > li > a, .nav_accordion > dd > div > ul > li > a').click(function() {
    horizon.modals.modal_spinner(gettext("Loading"));
  });

Suggestion 2:
    // panel selection
  $('.nav_accordion > dd ul > li > a').click(function() {
    horizon.modals.modal_spinner(gettext("Loading"));
  });