select_destinations should send start/end notifications

Bug #1359835 reported by John Garbutt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Sylvain Bauza

Bug Description

In the filter scheduler, schedule_run_instance sends notifications, but select_destinations does not.

This is inconsistent, and we should send start/end notifications from both code paths.

Tags: scheduler
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116022

Changed in nova:
assignee: John Garbutt (johngarbutt) → Sylvain Bauza (sylvain-bauza)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/116022
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=926f94534da7b3cd868eb6495a2eaadd5faff6b9
Submitter: Jenkins
Branch: master

commit 926f94534da7b3cd868eb6495a2eaadd5faff6b9
Author: John Garbutt <email address hidden>
Date: Thu Aug 21 16:58:13 2014 +0100

    scheduler sends select_destinations notifications

    scheduler_run_instance sends start/end notifications so you can tell how
    long it takes for the scheduler to do its work.

    The new select_destinations does not send any such notifications.

    To make the new code patch more consistent with the notifications in the
    old code patch, this change adds in start/end notifications.

    The notification docs should be updated to reflect this change.

    DocImpact

    Closes-Bug: #1359835

    Change-Id: I9b3f6619823c57cbc21d714edd78527c0015b4f6

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.