swift-drive-audit: additional exit codes

[Filippo Giunchedi]

Hi,
we found it useful to have more detailed exit statues from swift-drive-audit on the actions it performed, I'm attaching a patch to explain the general idea. Let me know if you find it useful!

thanks,
filippo

[clayg (clay-gerrard)]

I like the idea of more information encoded in the exit status - we could probably adopt the idea in other places. Do you wanna get it up in gerrit?!

I didn't know about the os.EX_* attributes; and EX_OK (0), EX_CONFIG (78), EX_USAGE (64), EX_OSFILE (72) all seem to be defined on my Mac and Ubuntu dev machines; but I worry they may not be on every system that's currently running the drive audit script? [1]

1. http://bugs.python.org/issue9933

[Filippo Giunchedi (filippo)]

thanks for the quick reply!

re: gerrit I'm a bit snowed under at the moment so that might happen in the next two/three weeks but wanted to send this out and get the ball rolling

good point about the platform, I checked google and github and they seem to be defined back to minix too https://github.com/minix3/minix/blob/master/include/sysexits.h and didn't check directly but if osx/mach defines them chances are that also other BSDs do. I'm assuming windows is not a target platform is it? :)

[Filippo Giunchedi (filippo)]

okay I've signed the ICLA and the wikimedia foundation has signed the CCLA, we should be set!

review at https://review.openstack.org/#/c/124398/

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Dickinson (<email address hidden>) on branch: master
Review: https://review.openstack.org/124398
Reason: Abandoning due to lack of activity since the last negative review. You can restore the change if you want to keep working on it.

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Dickinson (<email address hidden>) on branch: master
Review: https://review.openstack.org/124398
Reason: Abanoning based on the lack of activity since the last negative review. If you want to continue working on this, please reopen this patch.