Extra loop in populate_network_choices when launching instance

[Liyingjun]

There is an extra loop in populate_network_choices in launch instance workflow.
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L590-L592

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/115489

[Gary W. Smith (gary-w-smith)]

While it is true that the same network list is iterated twice, this change would only have a benefit if the list of networks were very large.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115489
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d02c9f4acdffef047d49d0c3568831ccf2373e1a
Submitter: Jenkins
Branch: master

commit d02c9f4acdffef047d49d0c3568831ccf2373e1a
Author: liyingjun <email address hidden>
Date: Thu Aug 7 08:31:53 2014 +0800

    Remove extra loop in populate_network_choices

    There is an extra loop in populate_network_choices in launch instance
    workflow, this could be merged into one loop.

    Change-Id: I03a988e95f23367ebc41fc13b7f08dfd2d9da9b7
    Closes-bug: 1359026