Dropdowns in table filters should be consistent

Bug #1358909 reported by Jeffrey Calcaterra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Low
Unassigned

Bug Description

In the dropdowns for choosing the column filters in tables, all of the items need to have "=" signs. Having a mixture is confusing.

Revision history for this message
Justin Pomeroy (jpomero) wrote :

The "=" sign is to indicate that the value must exactly match the filter value. There are some fields that require this and others that do not, and it depends on the service API support. No "=" sign means the field can be filtered on a subset of characters.

We should probably add some help text to this field to indicate what the "=" symbol means.

Justin Pomeroy (jpomero)
Changed in horizon:
assignee: nobody → Justin Pomeroy (jpomero)
Changed in horizon:
status: New → Confirmed
Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

I also find this confusing. For example in Admin > Images, the filters include 'Image Name =' and 'Min. Size (MB)'; i.e. the former has an = and the latter does not. In this case, both should be =, or the second should be reworded to 'Size (MB) >='. Better yet would be to simply avoid the = altogether, except for those few cases (are there any?) where it is not an equality relation.

Changed in horizon:
importance: Undecided → Low
Revision history for this message
Justin Pomeroy (jpomero) wrote :

Here is the breakdown of the current API filtering support by table:

Admin -> Images
-------------------
Image Name (equals)
Status (equals)
Format (equals)
Min. Size (MB) (greater than or equal to)
Max. Size (MB) (less than or equal to)

Admin -> Instances
----------------------
Project (equals) (Not an API filter)
Host (equals)
Name (contains)
IPv4 Address (equals)
IPv6 Address (equals)
Status (equals)
Image ID (equals)
Flavor ID (equals)

Project -> Instances
-----------------------
Instance Name (contains)
Status (equals)
Image ID (equals)
Flavor ID (equals)

Maybe there is some better way to indicate these filtering differences besides the "="?

Revision history for this message
Jeffrey Calcaterra (jacalcat) wrote :

Two things come to mind:
1. Change the help text in the search box depending on the dropdown selection-it could say "show greater than or equal to", "show exact matches", "show partial matches". The wording needs some work but that is the idea.

2. Put read only symbols inside the text box that indicate the type of matching which change dynamically based on the dropdown, for example, quotes for exact matches, ">=", etc. It could also be on the outside of the text box, but it looks a little strange.

These could both be done together to make the meaning clearer.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121130

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/121130
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Justin Pomeroy (jpomero)
Changed in horizon:
assignee: Justin Pomeroy (jpomero) → nobody
Eddie Ramirez (ediardo)
Changed in horizon:
assignee: nobody → Eddie Ramirez (ediardo)
Revision history for this message
Akihiro Motoki (amotoki) wrote :

I think the issue has been addressed so far. Marking this as Invalid.
If there is a remaining issue, please file a new bug.

Changed in horizon:
assignee: Eddie Ramirez (ediardo) → nobody
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.