instance.create.end notification may not be sent if the instance is deleted during boot

[Andrew Laski]

If an instance is deleted at a point during the virt driver.spawn() method that doesn't raise an exception, or while the power state is being updated, then the instance.save() which sets the final power state, vm_state, task_state, and launched_at will raise InstanceNotFound or UnexpectedDeletingTaskStateError and cause the final create.end notification to be skipped. This could have implications for billing/usage in a deployment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/115339

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115339
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c51be0903f2d20bdf1ea968efc57f4c6b979cb6f
Submitter: Jenkins
Branch: master

commit c51be0903f2d20bdf1ea968efc57f4c6b979cb6f
Author: Andrew Laski <email address hidden>
Date: Tue Aug 19 12:24:51 2014 -0400

    Send create.end notification even if instance is deleted

    There was an unprotected instance.save() call which could raise an
    exception and bypass a create.end notification. This adds a try/except
    block around that call with appropriate handling of the exception.

    Change-Id: I308ee84f6ab2bb37ef6570ff896017615a5bf746
    Closes-bug: #1358795