RelationSetCommand.Run() does not check all errors
Bug #1358585 reported by
Ian Booth
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Ian Booth | ||
1.20 |
Fix Released
|
High
|
Ian Booth |
Bug Description
There is a bug in RelationSetComm
settings, err := r.Settings()
for k, v := range c.Settings {
if v != "" {
settings.Set(k, v)
} else {
settings.
}
}
The error from r.Settings() is not checked. This can lead to a panic if there is an issue. See bug 1356500.
summary: |
- RelationSetCommand.Run() does check all errors + RelationSetCommand.Run() does not check all errors |
Changed in juju-core: | |
assignee: | nobody → Ian Booth (wallyworld) |
status: | Triaged → In Progress |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.