RelationSetCommand.Run() does not check all errors

Bug #1358585 reported by Ian Booth
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Ian Booth
1.20
Fix Released
High
Ian Booth

Bug Description

There is a bug in RelationSetCommand.Run().

 settings, err := r.Settings()
 for k, v := range c.Settings {
  if v != "" {
   settings.Set(k, v)
  } else {
   settings.Delete(k)
  }
 }

The error from r.Settings() is not checked. This can lead to a panic if there is an issue. See bug 1356500.

Ian Booth (wallyworld)
summary: - RelationSetCommand.Run() does check all errors
+ RelationSetCommand.Run() does not check all errors
Ian Booth (wallyworld)
Changed in juju-core:
assignee: nobody → Ian Booth (wallyworld)
status: Triaged → In Progress
Ian Booth (wallyworld)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.