OpenStack Heat

We shouldn't call resource_id_set(None) during deletion

Bug #1358492 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Thomas Herve
OpenStack Heat 2014.2 "juno"

Bug Description

Currently, some resources (but not all) do a resource_id_set(None) after deletion. That used to allow skipping handle_delete if resource_id is not set, but it's useless now.

See original description
Thomas Herve (therve)
summary: - We should check resource state before calling handle_delete
+ We shouldn't call set_resource_id(None) during deletion
description: updated
Thomas Herve (therve)
summary: - We shouldn't call set_resource_id(None) during deletion
+ We shouldn't call resource_id_set(None) during deletion
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/115285

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/115285
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5760718ba531c26a5961b53b430cf37539bfcce5
Submitter: Jenkins
Branch: master

commit 5760718ba531c26a5961b53b430cf37539bfcce5
Author: Thomas Herve <email address hidden>
Date: Mon Aug 18 17:23:11 2014 -0400

    Remove resource_id_set(None) calls

    This removes resetting resource_id in delete, as the state is storing
    that information properly, and it doesn't provide any additional value.

    Change-Id: I71f17ab79adbad5286389c87f1fbd5c60c4a8d7f
    Closes-Bug: #1358492

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.