IpNetnsCommand will refuse to work without root_helper

Bug #1358196 reported by Miguel Angel Ajo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Miguel Angel Ajo

Bug Description

The network namespace is not mandatory, but that makes
root_wrap non mandatory too, because you could
want to start non-privileged processes outside a
namespace through the same API, covering both
the namespace & non-namespace needs.

summary: - neutron/agent/linux/ip_lib.py will refuse to work without root_helper
+ IpNetnsCommand will refuse to work without root_helper
description: updated
Revision history for this message
Miguel Angel Ajo (mangelajo) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/114928

Changed in neutron:
assignee: nobody → Miguel Angel Ajo (mangelajo)
status: New → In Progress
Changed in neutron:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/114928
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eca9069be3d730c788e433edb291123eede07839
Submitter: Jenkins
Branch: master

commit eca9069be3d730c788e433edb291123eede07839
Author: Miguel Angel Ajo <email address hidden>
Date: Mon Aug 18 12:50:58 2014 +0200

    Fix IpNetnsCommand to execute without root_wrapper when no netns

    IpNetnsCommand accept execution with a network namespace, and
    that requires root privileges and a root_wrapper.
    IpNetnsCommand does accept no namespace too, in that case, the
    root_wrapper doesn't have to be present necessarily, unless the
    command we're executing requires root privileges itself.

    This patch fixes the check condition on IpNetnsCommand execute
    method.

    Change-Id: I5ab2f3f1daf4a5a080611dbcd3dbd43292f6766a
    Closes-Bug: #1358196

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.