stack name validation is not handled at engine.service._validate_new_stack()

Bug #1358192 reported by Kanagaraj Manickam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Invalid
Medium
Kanagaraj Manickam

Bug Description

Stack name is restricted to the following regx, in stack.Stack class, but it needs to be validated at the service:_validate_new_stack() (line 487) level as it take care of validating the all parameters specific to the Stack.

[a-zA-Z][a-zA-Z0-9_.-]*$

This bug is filed to do the stack validation at one place before creating a stack that is in service:_validate_new_stack() method

Changed in heat:
assignee: nobody → Kanagaraj Manickam (kanagaraj-manickam)
description: updated
Steven Hardy (shardy)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122630

Changed in heat:
status: Triaged → In Progress
Revision history for this message
Unmesh Gurjar (unmesh-gurjar) wrote :

IMO, with this change, the validation in Stack initialization (in https://github.com/openstack/heat/blob/master/heat/engine/stack.py#L86) is no longer required. Or am I overlooking something here?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Kanagaraj Manickam (<email address hidden>) on branch: master
Review: https://review.openstack.org/122630
Reason: This patch is submitted for the intentions of improving the stack name validation, though the current code is sufficient for the name validation. Its just a minute improvement patch on speed as Steven hardy mentioned. At this moment its fine with going with current code itself. so i am abandoning it for now.

Changed in heat:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.