stack name validation is not handled at engine.service._validate_new_stack()

[Kanagaraj Manickam]

Stack name is restricted to the following regx, in stack.Stack class, but it needs to be validated at the service:_validate_new_stack() (line 487) level as it take care of validating the all parameters specific to the Stack.

[a-zA-Z][a-zA-Z0-9_.-]*$

This bug is filed to do the stack validation at one place before creating a stack that is in service:_validate_new_stack() method

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/122630

[Unmesh Gurjar (unmesh-gurjar)]

IMO, with this change, the validation in Stack initialization (in https://github.com/openstack/heat/blob/master/heat/engine/stack.py#L86) is no longer required. Or am I overlooking something here?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kanagaraj Manickam (<email address hidden>) on branch: master
Review: https://review.openstack.org/122630
Reason: This patch is submitted for the intentions of improving the stack name validation, though the current code is sufficient for the name validation. Its just a minute improvement patch on speed as Steven hardy mentioned. At this moment its fine with going with current code itself. so i am abandoning it for now.