Slave provisioning failing when trying to create a "slave of a slave"

Bug #1357707 reported by Denis M.
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Denis M.

Bug Description

Replication V1 should allow only flat hierarchy - one root replica
  with multiple read replicas. Trove should forbid attempts to create
  slave of slave of slave and so on.

Bug described at: https://review.openstack.org/#/c/98147/23/trove/instance/models.py,cm

Denis M. (dmakogon)
Changed in trove:
assignee: nobody → Denis M. (dmakogon)
milestone: none → juno-3
Denis M. (dmakogon)
Changed in trove:
importance: Undecided → Medium
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117298

Changed in trove:
status: New → In Progress
Changed in trove:
milestone: juno-3 → ongoing
Denis M. (dmakogon)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by Denis M. (<email address hidden>) on branch: master
Review: https://review.openstack.org/117298

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119771

Changed in trove:
assignee: Denis M. (dmakogon) → Iccha Sethi (iccha-sethi)
Changed in trove:
assignee: Iccha Sethi (iccha-sethi) → Denis M. (dmakogon)
Changed in trove:
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by iccha-sethi (<email address hidden>) on branch: master
Review: https://review.openstack.org/117298

Changed in trove:
assignee: Denis M. (dmakogon) → Riddhi (ridhi-j-shah)
Changed in trove:
assignee: Riddhi (ridhi-j-shah) → Denis M. (dmakogon)
Changed in trove:
assignee: Denis M. (dmakogon) → Riddhi (ridhi-j-shah)
Changed in trove:
assignee: Riddhi (ridhi-j-shah) → Denis M. (dmakogon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/119771
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=a91c9d32051c504b6d2321050b89e710b3649d0b
Submitter: Jenkins
Branch: master

commit a91c9d32051c504b6d2321050b89e710b3649d0b
Author: Denis Makogon <email address hidden>
Date: Mon Sep 8 16:58:21 2014 +0300

    Forbid replica provisioning from replica site

    Reasons:
    - Replication V1 should allow only flat hierarchy - one root replica
      with multiple read replicas. Trove should forbid attempts to create
      slave of slave of slave and so on.

    Changes:
     - adding validation step that forbids read replica provisioning if passed
       replica source (slave_if_id) is not an actual source (is a read replica any
       other replica source)
     - unit test added

    Co-Authored-By: Iccha Sethi <email address hidden>

    Change-Id: Ic467b2eb01194f95a30f7ce9d921d3fa942b086e
    Closes-Bug: #1357707

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
milestone: ongoing → kilo-1
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.