Big Switch: servermanager should retry on 503 instead of failing immediately

Bug #1357105 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Kevin Benton
Icehouse
Fix Released
Low
Kevin Benton

Bug Description

When the backend controller returns a 503 service unavailable, the big switch server manager immediately counts the server request as failed. Instead it should retry a few times because a 503 occurs when there are locks in place for synchronization during upgrade, etc.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/114379

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Changed in neutron:
importance: Undecided → Low
milestone: none → juno-3
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/114379
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=48a2221648f490540fdf1ee099d39b8e5230f053
Submitter: Jenkins
Branch: master

commit 48a2221648f490540fdf1ee099d39b8e5230f053
Author: Kevin Benton <email address hidden>
Date: Wed Aug 13 04:31:45 2014 -0700

    Big Switch: Retry on 503 errors from backend

    Retries requests to the backend controller up to 3
    additional times with 3 seconds in between each request
    if a 503 service unavailable message was returned.
    The scenarios that return 503 messages from floodlight
    are normally short lived locks for things like OpenStack
    synchronization or upgrade blocks. Retrying should work
    in the majority of cases.

    Closes-Bug: #1357105
    Change-Id: Ifacd3a384cfc797ba6d6af5f3c8649c333473259

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/121391

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/121391
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b201432e02b959484f70a252a6cca94845712c57
Submitter: Jenkins
Branch: stable/icehouse

commit b201432e02b959484f70a252a6cca94845712c57
Author: Kevin Benton <email address hidden>
Date: Wed Aug 13 04:31:45 2014 -0700

    Big Switch: Retry on 503 errors from backend

    Retries requests to the backend controller up to 3
    additional times with 3 seconds in between each request
    if a 503 service unavailable message was returned.
    The scenarios that return 503 messages from floodlight
    are normally short lived locks for things like OpenStack
    synchronization or upgrade blocks. Retrying should work
    in the majority of cases.

    Conflicts:
     neutron/tests/unit/bigswitch/test_servermanager.py

    Closes-Bug: #1357105
    Change-Id: Ifacd3a384cfc797ba6d6af5f3c8649c333473259
    (cherry picked from commit 48a2221648f490540fdf1ee099d39b8e5230f053)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.