Hyper-V driver fails while creating instances on Windows / Hyper-V Server 2008 R2

[Claudiu Belu]

Creating an instance on a Hyper-V / Windows Server 2008 R2 compute node fails due to a WMI exception. This happens while creating creating and configuring the resources to be added to the VM.

The resources already have set default values for certain properties, while other properties have NULL. Trying to set a new value over the NULL causes the exception:
code:
drive = self._get_new_resource_setting_data(res_sub_type)
drive.Parent = ctrller_path

exception:
2014-08-13 09:57:07.507 2468 TRACE nova.compute.manager [instance: a30cd0c2-77ce-43d1-8399-5a876aa9a4f6] x_wmi: <x_wmi: Unexpected COM Error (-2147352567, 'Exception occurred.', (0, u'SWbemObjectEx', u'Provider is not capable of the attempted operation ', None, 0, -2147217372), None)>

Trace:
http://paste.openstack.org/show/94293/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114251

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/116507

[OpenStack Infra (hudson-openstack)]

Change abandoned by Claudiu Belu (<email address hidden>) on branch: master
Review: https://review.openstack.org/114251

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116507
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b208f249d94535381f05b261a5c38446d1daf8cb
Submitter: Jenkins
Branch: master

commit b208f249d94535381f05b261a5c38446d1daf8cb
Author: Alessandro Pilotti <email address hidden>
Date: Sun Aug 24 16:51:22 2014 +0300

    Fixes Hyper-V driver WMI issue on 2008 R2

    Trying to assign properties on default Hyper-V resource setting data
    WMI objects results in an exceptions before Hyper-V 2012.
    Cloning the objects before assigning them solves the issue.

    A similar approach was previous already implemented and has been
    incorrectly removed during a refactoring.

    Co-Authored-By: Robert Tingirica <email address hidden>
    Change-Id: If119154f8b4756be9f98c8acd376003c52eff44f
    Closes-Bug: #1356884