Integration tests - selenium - public/private methods design flaw

[Tomáš Nováčik]

There is flaw in horizon integration test design, certain methods located in the pageobject(those methods interact with webelements) should be executed only in the scope of class and definitely not touched in the test case. Problem is that those methods are public and thus nothing suggest that those methods should not be used in a test case(accessed as public method of page). Therefore i suggest to make those methods protected(make them start with the '_' prefix).

List of methods: is_element_visible, fill_field_element, select_dropdown, select_dropdown_by_value

[Gary W. Smith (gary-w-smith)]

Moving to wishlist as this is not a bug with horizon proper but a recommended improvement of the integration test code to facilitate identifying horizon bugs.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112579
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f573ef714b4574a2fe77ef0f95e323b7c4280e73
Submitter: Jenkins
Branch: master

commit f573ef714b4574a2fe77ef0f95e323b7c4280e73
Author: dkorn <email address hidden>
Date: Thu Aug 7 16:06:18 2014 +0300

    Integration tests - BaseWebObject class

    I added BaseWebObject, a base class for all web element objects,
    i.e. both page objects and regions.
    The new class now contains several wrappers for driver's
    capabilities, which are required not only by the pages but other
    webelements as well, and used to be located within pageobject.
    The necessity arose while discussing the regions patch
    (https://review.openstack.org/#/c/102227/), that will be
    modified accordingly by tnovacik.

    In addition, I've made 6 methods private, as they should
    not be used outside the pages, definitely not by the tests.

    Partially implements blueprint: selenium-integration-testing
    Closes-Bug: #1354017
    Closes-Bug: #1356774

    Change-Id: Id65951160b2016cbdafd8417df48b1b5cd02f99f