stack-delete occasionally fails 'conflict: router interface cannot be deleted'

[Steve McLellan]

Occasionally (25 - 50% of the time) stack-delete fails with an error:

Conflict: Router interface for subnet 52cc1cac-108c-4799-9268-1d80b05a5fab on router 108eea7b-b846-40df-9f0d-c53c926b7608 cannot be deleted, as it is required by one or more floating IPs.

This is caused by https://bugs.launchpad.net/heat/+bug/1299259. Until it's fixed in heat, we can fix it by adding a dependency from floatingip to the router interface, which will stop the router interface being deleted before any floating IPs.

[Steve McLellan (sjmc7)]

Addition will be something like:

              - $routerInterfaceName: $net.name + '-ri-' + $net.id()
              - $template:
                  resources:
                    $fip_name:
+ depends_on: { get_resource: $routerInterfaceName}
                      type: 'OS::Neutron::FloatingIP'
                      properties:
                        floating_network_id: $extNetId

BUT... only if If: $net.externalRouterId != null, which makes it a bit trickier.

[Steve McLellan (sjmc7)]

Note easiest way is likely:

- If: $net.externalRouterId != null
  Then:
    - $template.resources.$fip_name.depends_on: { get_resource: $routerInterfaceName}

This should cause heat to delete the router interface after the floating ip stuff. Eventually 1299259 will make it unnecessary, so include a comment to that effect.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/115336

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115336
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=e7f676635ba0e537c92964241b17fb9693deeef2
Submitter: Jenkins
Branch: master

commit e7f676635ba0e537c92964241b17fb9693deeef2
Author: Steve McLellan <email address hidden>
Date: Tue Aug 19 11:12:34 2014 -0500

    Fix occasional deletion failure

    Stack-delete was failing periodically because of heat bug
    https://bugs.launchpad.net/heat/+bug/1299259, whereby there's
    an implicit dependency from floating IPs to the router interface.
    There is a fix in progress for heat, but until then, this patch
    adds an explicit depends_on to the router interface.

    Change-Id: I846abf1fbd90d5f5c71b1c13941463743ace48ad
    Closes-Bug: 1356721