WSGI unittest fails if HTTP_PROXY if set
Bug #1356665 reported by
Angus Lees
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Undecided
|
Angus Lees | ||
Icehouse |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
urllib2.urlopen uses $http_proxy/
default. If set (and pointing to a remote host), then the WSGI tests
that spin up a local server and connect to it using
http://
and (hopefully) fail.
We shouldn't follow HTTP_PROXY when trying to connect to test servers.
Changed in neutron: | |
assignee: | nobody → Angus Lees (gus) |
status: | New → In Progress |
Changed in neutron: | |
milestone: | none → juno-3 |
status: | Fix Committed → Fix Released |
Changed in neutron: | |
milestone: | juno-3 → 2014.2 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/110853 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=6d7b2e007cf 477a7f212312bad 4ce0cbe8032d1a
Committed: https:/
Submitter: Jenkins
Branch: master
commit 6d7b2e007cf477a 7f212312bad4ce0 cbe8032d1a
Author: Angus Lees <email address hidden>
Date: Thu Jul 31 15:27:18 2014 +1000
Ignore http_proxy while connecting to test WSGI server
urllib2.urlopen uses $http_proxy/ $HTTP_PROXY environment variables by 127.0.0. 1:$port/ instead connect to $port *on the proxy*,
default. If set (and pointing to a remote host), then the WSGI tests
that spin up a local server and connect to it using
http://
and (hopefully) fail.
This change uses urllib2 in a way that ignores proxy settings.
Change-Id: I4d94fcc06925d0 c947345a07ae203 52e1898e46d
Closes-Bug: #1356665