update_statuses_on_time_out looks up an instance from the DB by name

[Nikhil Manchanda]

update_statuses_on_time_out moves an instance from BUILD state to ERROR state in case it has been building for longer than a "usage_timeout" value (s).

However, it looks up the instance by name instead of ID. This potentially means that we update the wrong instance to ERROR, since name is not unique.

https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L291-294

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114095

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114095
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=52e1dc1b754fea6ec554c53e59df72606a8a36c4
Submitter: Jenkins
Branch: master

commit 52e1dc1b754fea6ec554c53e59df72606a8a36c4
Author: Nikhil Manchanda <email address hidden>
Date: Wed Aug 13 18:00:34 2014 -0700

    Look up trove instance by ID instead of name

    update_statuses_on_time_out looks up the instance by name instead of ID.
    This potentially means that we update the wrong instance to ERROR, since
    instance name is not unique. This patchset fixes this issue by looking
    up the trove instance by ID instead of name.

    Change-Id: If9c7a518f50098390567d8e4df0f948b7d3be2c6
    Closes-bug: 1356647