Create a DVR router with Gateway info does not create a SNAT namespace on the "dvr_snat" node

[Swaminathan Vasudevan]

Creating a DVR Router with Gateway in a single REST API or a single python neutronclient CLI command does not create a SNAT namespace in the 'dvr_snat" node even when we add an interface to the router.

How to reproduce it.

1. Configure a dvr_snat node.
2. Create Networks - Private and Public
3. Create Subnets - Private-Subnet1 and Public-Subnet2
4. Create a DVR router with Gateway enabled.
5. Now add Private-Subnet1 to the router.
6. Run "ip netns list".
7. You will not see any qrouter namespace and snat namespace.

[Carl Baldwin (carl-baldwin)]

If you boot a VM on the network, does the snat namespace get created?

[Swaminathan Vasudevan (swaminathan-vasudevan)]

Carl, Yes after creating a router, even if we boot a VM on the network, the snat namespaces are not created in this case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118704

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118705

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118706

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118707

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118704
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=43637f257f353254bf3bb68e5b7631ae1aacd831
Submitter: Jenkins
Branch: master

commit 43637f257f353254bf3bb68e5b7631ae1aacd831
Author: Michael Smith <email address hidden>
Date: Tue Sep 2 16:59:36 2014 +0000

    Add scheduler unit tests to enable bug fixes and refactoring

    Improves the coverage for DVR scheduling and will allow safer bug
    fixes and refactoring in follow-on patches.

    Change-Id: I02d0126e31adcab88a7ee82ba1cb76f952c9a68c
    Partial-bug: #1353266
    Partial-bug: #1356639
    Co-Authored-By: Swaminathan Vasudevan <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118705
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f31a56a06c01adecfeaa679b49243c24accb65d1
Submitter: Jenkins
Branch: master

commit f31a56a06c01adecfeaa679b49243c24accb65d1
Author: Michael Smith <email address hidden>
Date: Tue Sep 2 17:05:12 2014 +0000

    Remove subnet_id from check_ports_exist_on_l3agent

    Refactor check_ports_exist_on_l3agent so that subnet_id no longer
    needs to be passed. Instead it calls get_subnet_ids_on_router. This
    helps to pave the way for removing hints from schedule router.

    Partial-bug: #1353266
    Partial-bug: #1356639
    Co-Authored-By: Swaminathan Vasudevan <email address hidden>

    Change-Id: I6e9dcb0b899294bb4cf3e3d616a0a690049c338e

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118706
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=671e3ffa468974bf3b52f787e865eba2b6c97ffe
Submitter: Jenkins
Branch: master

commit 671e3ffa468974bf3b52f787e865eba2b6c97ffe
Author: Michael Smith <email address hidden>
Date: Tue Sep 2 17:07:04 2014 +0000

    Call unbind_snat_servicenode from schedule router

    Refactor to move the call to plugin.unbind_snat_servicenode from
    schedule_snat_router to _schedule_router. This is a move to pave the
    way for removing hints from schedule router.

    Partial-bug: #1353266
    Partial-bug: #1356639
    Co-Authored-By: Swaminathan Vasudevan <email address hidden>

    Change-Id: I062d8cc3cb870bbaa033d5b107a7dd868dfafa19

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118707
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=357404e73427aeb4a45c2b226706703f4f846dfc
Submitter: Jenkins
Branch: master

commit 357404e73427aeb4a45c2b226706703f4f846dfc
Author: Michael Smith <email address hidden>
Date: Tue Sep 2 17:08:06 2014 +0000

    Remove hints from schedule_router

    Partial-bug: #1353266
    Partial-bug: #1356639
    Co-Authored-By: Swaminathan Vasudevan <email address hidden>

    Change-Id: Ie6b55e5d0d70be74b19c91994e52eb1719e32fef

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114410
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5a36f0ad24903a3a8ec213840ab164834917a32e
Submitter: Jenkins
Branch: master

commit 5a36f0ad24903a3a8ec213840ab164834917a32e
Author: Michael Smith <email address hidden>
Date: Tue Sep 2 17:09:12 2014 +0000

    Avoid an extra database query in schedule_snat_router

    bind_snat_servicenode already knows the chosen_agent. By waiting
    until after it is called, we can use it to avoid another db query.

    Closes-bug: #1353266
    Closes-bug: #1356639
    Co-Authored-By: Swaminathan Vasudevan <email address hidden>

    Change-Id: Iba5668b2717e188d5289ede982bfc1b46f4eeb5b