manila: pylint wrong continued indentation issues

[Danny Al-Gaaf]

pylint reports many bad-continuation issues within the manila codebase.

+-----------------+------------+
|message id |occurrences |
+=================+============+
|bad-continuation |562 |
+-----------------+------------+

For example:

************* Module manila.volume.cinder
C: 38, 0: Wrong continued indentation.
            default='volume:cinder:publicURL',
            ^ | (bad-continuation)

[Valeriy Ponomaryov (vponomaryov)]

Change was merged: https://github.com/stackforge/manila/commit/2c950c49432f8a2d0a607eebaad4401a414b3349

[Danny Al-Gaaf (danny-al-gaaf)]

@vponomaryov: the merge is about a different bug #1356524

[Ben Swartzlander (bswartz)]

Is this bug still valid? I don't know much about pylint...

[Luis Pabón (lpabon)]

I am going to see if I can confirm this bug.

[Luis Pabón (lpabon)]

From what I can tell, the program tools/lintstack.py which is executed by tools/lintstack.sh when Jenkins runs, only tests for differences in the output of pylint. Right now, there seems to be 17 errors/warnings that are being carried over from fix to fix, with no difference between fixes, and so no failures in the pylint Jenkins job.

It is really difficult to tell what the errors are, so I added a fix to tools/lintstack.sh which will help developers determine what the errors are, and we can fix them as needed.

The fix will be up soon.

[Luis Pabón (lpabon)]

Sample output of `tox -e lint`

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170553

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170553
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=72d2840048c6aba344ea9ba08f301ef5dc5226a2
Submitter: Jenkins
Branch: master

commit 72d2840048c6aba344ea9ba08f301ef5dc5226a2
Author: Luis Pabón <email address hidden>
Date: Fri Apr 3 11:21:40 2015 -0400

    Enable developers to see pylint output

    The program tools/lintstack.py which is executed by
    tools/lintstack.sh when Jenkins runs, only tests for differences
    in the output of pylint. Right now, there seems to be
    17 errors/warnings that are being carried over from fix to fix,
    with no difference between fixes, and so no failures in the
    pylint Jenkins job.

    It is really difficult to tell what the errors are, so this fix
    allows developers determine what the errors are by running the
    following command:

    $ tox -e lint

    A sample output of the command is available as an attachment
    to the bug.

    Change-Id: I88487829576d55d437b934e08571013b7a6e57cf
    Signed-off-by: Luis Pabón <email address hidden>
    Closes-Bug: #1356588
    Signed-off-by: Luis Pabón <email address hidden>