SIP config option check (use_sip_date_format) warns on typo

Bug #1356576 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.5
Fix Released
Undecided
Unassigned
2.6
Fix Released
Undecided
Unassigned

Bug Description

Warning:

Use of uninitialized value in bitwise or (|) at /usr/local/share/perl/5.10.1/OpenILS/SIP.pm line 209, <GEN4869> line 1.

Caused by:

my $use_sdf = $class->get_option_value('use_sip_date_format') | '';

The "|" should of course be a "||".

Note that the code still functions as expected, albeit loudly. Patch en route...

Tags: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :
Changed in evergreen:
milestone: none → 2.5.7
milestone: 2.5.7 → 2.next
tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

I hate typos. Thanks Bill! Pushed to master and backported to rel_2_6 and rel_2_5 as a bug fix.

no longer affects: evergreen/2.7
Changed in evergreen:
milestone: 2.next → 2.7.0
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.