bad indentation in manila code

Bug #1356524 reported by Danny Al-Gaaf
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Danny Al-Gaaf

Bug Description

pylint finds several cases of bad indentation:

pylint --disable=all --enable=W0311 manila

************* Module manila.share.configuration
W: 71, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
************* Module manila.share.drivers.generic
W:504, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
************* Module manila.share.drivers.netapp.driver
W:338, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
************* Module manila.share.drivers.netapp.cluster_mode
W:649, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
************* Module manila.tests.test_share_glusterfs
W:165, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
************* Module manila.tests.test_migrations
W:121, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
************* Module manila.tests.fake_network
W:129, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:130, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:131, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
W:132, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:134, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:136, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
************* Module manila.tests.api.contrib.test_services
W:104, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:105, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:109, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:110, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:114, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:115, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:119, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:120, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:124, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:125, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:129, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:130, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:134, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:135, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
************* Module manila.tests.api.contrib.test_share_actions
W: 35, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W: 36, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W: 37, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W: 38, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W: 39, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W: 40, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W: 41, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W: 42, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W: 43, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W: 45, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W: 46, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W: 48, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W: 49, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)

Changed in manila:
assignee: nobody → Danny Al-Gaaf (danny-al-gaaf)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113995

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/113995
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=2c950c49432f8a2d0a607eebaad4401a414b3349
Submitter: Jenkins
Branch: master

commit 2c950c49432f8a2d0a607eebaad4401a414b3349
Author: Danny Al-Gaaf <email address hidden>
Date: Wed Aug 13 20:54:19 2014 +0200

    Fix bad indentation in manila

    Closes-Bug: #1356524

    Change-Id: I23557b768c53de0fb56c8dbbfe63f6baa5831ec5
    Signed-off-by: Danny Al-Gaaf <email address hidden>

Changed in manila:
status: In Progress → Fix Committed
Changed in manila:
status: Fix Committed → Fix Released
Changed in manila:
milestone: none → juno-3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.