invalid exceptions used in start_shellinabox_console

Bug #1356408 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Ruby Loo

Bug Description

in ironic.drivers.modules.console_utils.start_shellinabox_console(), these exceptions are used:

    exception.ProcessExecutionError, exception.UnknownArgumentError

but they don't exist and would result in a runtime error. They should be processutils.ProcessExecutionError & processutils.UnknownArgumentError.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113939

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/113939
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1b526e1f4836327350a97b4a9569b2f4a2a6f6c9
Submitter: Jenkins
Branch: master

commit 1b526e1f4836327350a97b4a9569b2f4a2a6f6c9
Author: Ruby Loo <email address hidden>
Date: Wed Aug 13 15:38:30 2014 +0000

    Use valid exception in start_shellinabox_console

    Replace non-existing exception exception.ProcessExecutionError
    with the correct exception from processutils.

    Remove non-existing exception exception.UnknownArgumentError
    because it was meant to be processutils.UnknownArgumentError
    which isn't needed since it is only raised if there are
    unknown arguments in kwargs, which there aren't in this case
    (only 'check_exit_code' is there.)

    Adds a unit test that checks for the ProcessExecutionError
    exception.

    Change-Id: I756f78bd8d8976a638169ee9db712a95dc664b58
    Closes-Bug: #1356408

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.