bad indentation in netapp and san driver

Bug #1356223 reported by Danny Al-Gaaf
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Danny Al-Gaaf

Bug Description

pylint finds cases of bad indentation:

************* Module cinder.volume.drivers.netapp.common
W:146, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
************* Module cinder.volume.drivers.netapp.utils
W:197, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:207, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:208, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:209, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:210, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:211, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:212, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:213, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:214, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:215, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:216, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:217, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:218, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:219, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:220, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:221, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:222, 0: Bad indentation. Found 8 spaces, expected 4 (bad-indentation)
W:232, 0: Bad indentation. Found 20 spaces, expected 12 (bad-indentation)
************* Module cinder.volume.drivers.netapp.eseries.client
W:127, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:129, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:130, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:133, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
************* Module cinder.volume.drivers.netapp.ssc_utils
W:421, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:422, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:427, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:428, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:429, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:430, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:431, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
W:432, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
W:433, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
W:434, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:435, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
W:436, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:437, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:438, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
W:439, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:440, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:441, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:442, 0: Bad indentation. Found 28 spaces, expected 24 (bad-indentation)
W:443, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:444, 0: Bad indentation. Found 28 spaces, expected 24 (bad-indentation)
W:445, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:446, 0: Bad indentation. Found 28 spaces, expected 24 (bad-indentation)
W:447, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:448, 0: Bad indentation. Found 28 spaces, expected 24 (bad-indentation)
W:449, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:450, 0: Bad indentation. Found 28 spaces, expected 24 (bad-indentation)
W:451, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:452, 0: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
W:453, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:454, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:455, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:456, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:506, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:507, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:518, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
W:519, 0: Bad indentation. Found 12 spaces, expected 8 (bad-indentation)
************* Module cinder.volume.drivers.netapp.nfs
W:275, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:276, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:279, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:280, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:281, 0: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
W:355, 0: Bad indentation. Found 28 spaces, expected 24 (bad-indentation)
W:356, 0: Bad indentation. Found 28 spaces, expected 24 (bad-indentation)
W:357, 0: Bad indentation. Found 32 spaces, expected 28 (bad-indentation)
************* Module cinder.volume.drivers.netapp.iscsi
W:1226, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
************* Module cinder.volume.drivers.san.hp.hp_3par_common
W:421, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)
W:422, 0: Bad indentation. Found 24 spaces, expected 20 (bad-indentation)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113803

Changed in cinder:
assignee: nobody → Danny Al-Gaaf (danny-al-gaaf)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/113803
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=58908e6d6c6bbad1c7bc4144a7b42f0fde3485cd
Submitter: Jenkins
Branch: master

commit 58908e6d6c6bbad1c7bc4144a7b42f0fde3485cd
Author: Danny Al-Gaaf <email address hidden>
Date: Wed Aug 13 09:49:06 2014 +0200

    Fix bad indentation in netapp and san.hp volume drivers

    Closes-Bug: #1356223

    Change-Id: I4e9fb3c6b3e098998f41e266b2cfc51a4af1fc65
    Signed-off-by: Danny Al-Gaaf <email address hidden>

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.