MongoDB driver does not take claim grace into account on update

Bug #1356184 reported by Kurt Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
High
Flavio Percoco

Bug Description

When a claim is updated, the associated messages have their lifetimes extended and their TTL updated without taking into account the claim's grace period as is done in the create method of ClaimController.

In fixing this, we should consider finding a way to DRY up these two methods to avoid this sort of bug in the future!

Changed in marconi:
status: New → Triaged
importance: Undecided → High
Changed in zaqar:
assignee: nobody → Flavio Percoco (flaper87)
milestone: none → juno-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zaqar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/127518

Changed in zaqar:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zaqar (proposed/juno)

Fix proposed to branch: proposed/juno
Review: https://review.openstack.org/128659

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/127518
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=c54f922c33493dca946760514e741507d90f6a08
Submitter: Jenkins
Branch: master

commit c54f922c33493dca946760514e741507d90f6a08
Author: Flavio Percoco <email address hidden>
Date: Fri Oct 10 14:50:29 2014 +0200

    Fix ttl and grace story for claims updates

    Claim's updates are currently extending the life of a claim by extending
    its `ttl` without taking into account the claim's grace. In addition to
    this, the `ttl`'s default value is 60 for claim's renewal instead of
    being the value of the configured default ttl.

    This patch allows users to specify a `grace` when renewing a claim. If
    `grace` is not present, it'll use the configured default value for it.

    The change doesn't break backwards compatibility as in v1_0 a ttl *is*
    required for claims renewal.

    Closes-bug: #1356184
    Change-Id: I9cce93c65f6d14ed8fabbbbcb9bf7ddc3bc11af2

Changed in zaqar:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (proposed/juno)

Reviewed: https://review.openstack.org/128659
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=6d0160f0e90b5513e66a6844a2eac9021752a9e3
Submitter: Jenkins
Branch: proposed/juno

commit 6d0160f0e90b5513e66a6844a2eac9021752a9e3
Author: Flavio Percoco <email address hidden>
Date: Fri Oct 10 14:50:29 2014 +0200

    Fix ttl and grace story for claims updates

    Claim's updates are currently extending the life of a claim by extending
    its `ttl` without taking into account the claim's grace. In addition to
    this, the `ttl`'s default value is 60 for claim's renewal instead of
    being the value of the configured default ttl.

    This patch allows users to specify a `grace` when renewing a claim. If
    `grace` is not present, it'll use the configured default value for it.

    The change doesn't break backwards compatibility as in v1_0 a ttl *is*
    required for claims renewal.

    Closes-bug: #1356184
    Change-Id: I9cce93c65f6d14ed8fabbbbcb9bf7ddc3bc11af2

Changed in zaqar:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in zaqar:
milestone: juno-rc2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.