make nova floating-ip-delete atomic with neutron
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
High
|
Aaron Rosen | ||
Havana |
Fix Released
|
High
|
Aaron Rosen | ||
Icehouse |
Fix Released
|
High
|
Aaron Rosen |
Bug Description
The infra guys were noticing an issue where they were leaking floating ip
addresses. One of the reasons this would occur for them is they called
nova floating-ip-delete which first disassocates the floating-ip in neutron
and then deletes it. Because it makes two calls to neutron if the first one
succeeds and the second fails it results in the instance no longer being
associated with the floatingip. They have retry logic but they base it on
the instance and when they go to retry cleaning up the instance the floatingip
is no longer on the instance so they never delete it.
This patch fixes this issue by directly calling delete_floating_ip instead
of releasing first if using neutron as neutron allows this. I looked into
doing the same thing for nova-network but the code is written to prevent this.
This allows the operation to be atomic. I know this is sorta hackish that
we're doing this in the api layer but we do this in a few other places
too fwiw.
Changed in nova: | |
importance: | Undecided → High |
assignee: | nobody → Aaron Rosen (arosen) |
tags: | added: network |
tags: | added: icehouse-backport-potential |
Changed in nova: | |
assignee: | Aaron Rosen (arosen) → Matt Riedemann (mriedem) |
Changed in nova: | |
assignee: | Matt Riedemann (mriedem) → Aaron Rosen (arosen) |
tags: | removed: icehouse-backport-potential in-stable-icehouse |
Changed in nova: | |
milestone: | none → juno-rc1 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | juno-rc1 → 2014.2 |
Fix proposed to branch: master /review. openstack. org/113754
Review: https:/