VPNaaS: Cisco validator incorrectly checking public IP of router

[Paul Michali]

The IPSec site connection validation checks that the router has a GW specified. It incorrectly accesses this information via the VPN service table.

As a result, all validations fail.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/113751

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/113751
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7370b3df04a9f5dddb3bddc9bf6f8b1f3c205d72
Submitter: Jenkins
Branch: master

commit 7370b3df04a9f5dddb3bddc9bf6f8b1f3c205d72
Author: Paul Michali <email address hidden>
Date: Tue Aug 12 21:26:27 2014 -0400

    VPNaaS: Cisco fix validation for GW IP

    The validation to check that the router has a GW IP
    for the Cisco service driver was trying to directly
    get the gw_port information, which is not available, as
    the validator only has a dict of the vpn_service info.

    Modified validator to get the router object (not a
    dict representation), using the vpn_service's router_id
    and then check the attributes for the router directly.

    Change-Id: I48286cda23d9737ddd90251dc0d1db1c310e7784
    Closes-Bug: 1356127