get_floating_ip_pools for neutron v2 API inconsistent with nova network API

Bug #1355882 reported by Salvatore Orlando
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Salvatore Orlando

Bug Description

Commit e00bdd7aa8c1ac9f1ae5057eb2f774f34a631845 change get_floating_ip_pools in a way that it now return a list of names rather than a list whose elements are in the form {'name': 'pool_name'}.

The implementation of this method in nova.network.neutron_v2.api has not been adjusted thus causing tempest.api.compute.floating_ips.test_list_floating_ips.FloatingIPDetailsTestJSON to always fail with neutron

The fix is straightforward.

Changed in nova:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
no longer affects: neutron
Changed in nova:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113554

Changed in nova:
status: Confirmed → In Progress
Matt Riedemann (mriedem)
tags: added: api network neutron
Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/113554
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d449b5d8556e67be08e016c94f9b1c523a69ce7e
Submitter: Jenkins
Branch: master

commit d449b5d8556e67be08e016c94f9b1c523a69ce7e
Author: Salvatore Orlando <email address hidden>
Date: Tue Aug 12 08:14:16 2014 -0700

    Neutron v2 API: fix get_floating_ip_pools

    Commit 7254f9b9dfbadadeb3aeda5d02bf37bfeb65e72d changed this method
    in nova.network.api in a way that it now returns simply a list of
    floating ip pool names, rather a list of dicts in the form

    {'name': 'pool_name'}

    The implementation of get_floating_ip_pools for neutron needs to
    be changed accordingly. Otherwise nova's floating ip extension
    will return a dict as floating ip pool names when neutron is enabled.

    Change-Id: I27001c9f17dad4dc4ca8cd032e689736553d8225
    Closes-Bug: #1355882

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.