config argument to config.setup_logging is unused

Bug #1355565 reported by Angus Lees
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Angus Lees

Bug Description

In neutron/common/config.py, the argument to setup_logging is unused:

  def setup_logging(conf):
     product_name = "neutron"
     logging.setup(product_name)
     LOG.info(_("Logging enabled!"))

As a minor cleanup, we should remove the argument in the interests of simpler code and avoiding confusion.

Changed in neutron:
assignee: nobody → Angus Lees (gus)
status: New → In Progress
Edgar Magana (emagana)
Changed in neutron:
importance: Undecided → Low
milestone: none → juno-3
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/111180
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5defcd0aa61b96933369a545040e57d9665add7a
Submitter: Jenkins
Branch: master

commit 5defcd0aa61b96933369a545040e57d9665add7a
Author: Angus Lees <email address hidden>
Date: Thu Jul 31 13:27:57 2014 +1000

    Remove unused arg to config.setup_logging()

    The cfg.CFG argument is ignored and misleading. This change removes it
    and updates all callers.

    Closes-Bug: #1355565
    Change-Id: I2fcece85d1abe848e5c01125cfb62c02f2dcbc86

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.