win client cannot build because src\gopkg.in\natefinch\npipe.v2 not found

Bug #1355219 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Critical
Nate Finch

Bug Description

We cannot compile the win client on master as of commit c436dc40 and d1b57c20. It last passed with commit af0b88e3.

http://juju-ci.vapour.ws:8080/job/win-client-build-installer/838/console

..\..\juju\sockets\sockets_windows.go:7:2: cannot find package "gopkg.in/natefinch/npipe.v2" in any of:
 C:\Go\src\pkg\gopkg.in\natefinch\npipe.v2 (from $GOROOT)
 C:\Users\Administrator\ci\gogo\src\gopkg.in\natefinch\npipe.v2 (from $GOPATH)

Revision history for this message
John Weldon (johnweldon4) wrote :

fix inadvertent removal of npipe.v2

Changed in juju-core:
assignee: nobody → John Weldon (johnweldon4)
Revision history for this message
Nate Finch (natefinch) wrote :

This is just dependencies.tsv getting out of sync with reality. I'm going to fix both that file and the fact that godeps doesn't list npipe in the dependencies by making npipe a dependency of the linux build. This is somewhat unfortunate, given that npipe is *not* a dependency of the linux build, but unless we stop using godeps for dependency management, or fix it, this is the only solution.

Changed in juju-core:
assignee: John Weldon (johnweldon4) → Nate Finch (natefinch)
Revision history for this message
Nate Finch (natefinch) wrote :

added npipe as a dependency for non-windows builds, after a slight modification to npipe so it was *possible* to import it on non-windows platforms.

Changed in juju-core:
status: Triaged → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.