Crazy high framerates

[Max Linke]

There seems to be a problem calculating the current framerate. I get values near absolute zero or crazy large values. I attached a screenshot.

[Daniel Schürmann (daschuer)]

e863 is the real time error counter.
But you are right, it is misleading and should be changed.

[Max Linke (max-linke)]

Ah now I remember something about it. YES we need to change that at
least rename it to error. This is exactly scientific notation there and
my brain is by now hardwired to read it like that.

On Mon, 2014-08-11 at 15:48 +0000, Daniel Schürmann wrote:
> e863 is the real time error counter.
> But you are right, it is misleading and should be changed.
>

[Max Linke (max-linke)]

That does the realTimeError Counter actually count? The number of missed frames?

[Dennis Rohner (midzer)]

I think the real time error counter has only marginal purpose for the user.
Either discard it completely or move it to a new Label right below "Average frame rate" (without scientific notification)

[jus (jus)]

+1
and display it only when running with --developer option, like we do for the VSyncTest waveform summary option

[RJ Skerry-Ryan (rryan)]

It counts vsync misses. It's useful for developers and useful to ask users
what theirs looks like if we are trying to figure out why their graphics
performance sucks. I'm for leaving it in but labeling it something more
friendly like "Hiccups" or "Glitches".

On Mon, Sep 15, 2014 at 5:13 PM, Dennis Rohner <email address hidden> wrote:

> I think the real time error counter has only marginal purpose for the user.
> Either discard it completely or move it to a new Label right below
> "Average frame rate" (without scientific notification)
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1355159
>
> Title:
> Crazy high framerates
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1355159/+subscriptions
>

[Max Linke (max-linke)]

What are we doing when we miss a vsync? Do we just drop the frame or paint it anyway?

Currently I would go with being accurate and renaming it to 'vsync misses'. It's also easy to understand and a better description then "Hiccups" or "Glitches"

[Daniel Schürmann (daschuer)]

The delayed frame is painted in the next frame (now current) . The frame for the current frame is dropped.
See:
https://github.com/mixxxdj/mixxx/blob/master/src/waveform/vsyncthread.cpp#L110

[Max Linke (max-linke)]

Good then i suggest we rename it to "dropped frames".

On September 16, 2014 1:21:11 PM CEST, "Daniel Schürmann" <email address hidden> wrote:
>The delayed frame is painted in the next frame (now current) . The
>frame for the current frame is dropped.
>See:
>https://github.com/mixxxdj/mixxx/blob/master/src/waveform/vsyncthread.cpp#L110
>
>--
>You received this bug notification because you are subscribed to the
>bug
>report.
>https://bugs.launchpad.net/bugs/1355159
>
>Title:
> Crazy high framerates
>
>Status in Mixxx:
> Confirmed
>
>Bug description:
> There seems to be a problem calculating the current framerate. I get
> values near absolute zero or crazy large values. I attached a
> screenshot.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/mixxx/+bug/1355159/+subscriptions

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[Max Linke (max-linke)]

PR https://github.com/mixxxdj/mixxx/pull/344

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7555