Do not send replies for messages recieved with empty msg_id

[Bogdan Dobrelya]

For rpc.cast/rpc.call (http://docs.openstack.org/developer/nova/devref/rpc.html for details), reply is expected by the Invoker side only if there was a msg_id specified in AMQP message.
But current implementation of AMQPIncomingMessage sends reply for messages with empty msg_id as well. That is a problem and should be fixed.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexei Kornienko (<email address hidden>) on branch: master
Review: https://review.openstack.org/109143
Reason: As openstack committers we all have same rights and same rules to follow. As reviewers some of us are trusted with rights to decide that patches are good enough to be merged.

However lately I have the feeling that while all developers are equal, some developers are more equal than others (https://review.openstack.org/#/c/107907/ , https://review.openstack.org/#/c/81193/ , https://review.openstack.org/#/c/38339/).
Because of this I'm really frustrated that I'm asked to follow the rules that others do not follow.

As I already said this change does not require a test. Since people here do not agree with me I abandon this change. Have a nice day to all of you :)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/115010

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115010
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=7381ccdc2afb71761b31f766be15ee21944d3650
Submitter: Jenkins
Branch: master

commit 7381ccdc2afb71761b31f766be15ee21944d3650
Author: Alexei Kornienko <email address hidden>
Date: Thu Jul 24 01:48:27 2014 +0300

    Should not send replies for cast messages

    Cast messages will not contain a msg_id and we're currently
    sending messages to the default excahgne with empty msg_id.
    In order to fix it we should not send replies if there is no
    msg_id in message.

    Change-Id: I5b1142029d2c718c3929cf6cf1f6e958b95a5c96
    Closes-bug: #1355058