Modal dialog with tab containers needs some styling

Bug #1354505 reported by Aaron Sahlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Jiri Tomasek

Bug Description

There are a couple of small styling issues with the Modal Dialogs.

1) The tabbed content needs to be shifted down
2) The white space above / below header needs to be reduced. Lots of wasted space. This applys to all dialogs.
3) Membership widgets '+' buttons are over-sized and overrun row boundaries. This doesn't apply only to just dialogs.

Attached and image for clarity.

Tags: bootstrap
Revision history for this message
Aaron Sahlin (asahlin) wrote :
Jiri Tomasek (jtomasek)
Changed in horizon:
assignee: nobody → Jiri Tomasek (jtomasek)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113519

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/113519
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4e9b5c2daadcaecd48554e3298983961e648e26e
Submitter: Jenkins
Branch: master

commit 4e9b5c2daadcaecd48554e3298983961e648e26e
Author: Jiri Tomasek <email address hidden>
Date: Wed Nov 19 17:38:24 2014 +0100

    Modal fixes - 2 columns, padding, header, membership

    Adds padding to tab-content which takes care of proper
    spacing between tabs and tab-content.
    refactors tabs styling - match modal and non-modal tabs
    Changes modal header h3 margin to save space.
    Cleans up Membership widget styling
    Unifies 2 column layout in modals using bootstrap columns
    Changes create and update image modal template as an example.
    The rest of the views is changed in subsequent patch

    Closes-Bug: #1354505
    Change-Id: Idca2a2dbdea8cdacc37061faa52004b1020b1bf0

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.