[nailgun] Nodes bond configuration is not cleared in all cases

Bug #1354492 reported by Aleksey Kasatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Aleksey Kasatkin

Bug Description

fuel-web/master "5bc33457e5a1f108b071ed0ef2a771ea0b610b22"

Nodes bond configuration must be cleared when node is removed from cluster.
It's done when node is removed via node handlers but it's missing when node is removed via cluster handler.

NetworkManager.clear_bond_configuration()

It's present here:

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/objects/node.py#L617

but not here:

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/objects/cluster.py#L363

Tags: nailgun
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112922

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/112922
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=7a0938f67c71466b24c79e4ea81fe34e203529b9
Submitter: Jenkins
Branch: master

commit 7a0938f67c71466b24c79e4ea81fe34e203529b9
Author: Aleksey Kasatkin <email address hidden>
Date: Fri Aug 8 18:05:39 2014 +0300

    Add clear_bond_configuration for removed nodes on cluster update

    Now bonds configuration is removed in all situations. Tests added.
    More generally, we need to DRY node removal code in those two places.

    Closes-Bug: #1354492

    Change-Id: I138df23b6a1da292ab928b59c479a1f3d7ba05a2

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.