Ironic

wrong usage of timeutils

Bug #1354443 reported by Andriy Kurilin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Andriy Kurilin
Ironic 2014.2 "juno"

Bug Description

Usage of timeutils from different places (from oslo.db and from ironic) can produce errors, so we should remove all imports 'oslo.db.openstack.common.timeutils' and use only timeutils from oslo.utils.

Revision history for this message
Dmitry Tantsur (divius) wrote :

https://review.openstack.org/#/c/112303 introduced a temporary hack in models. Needs to be fixed, once oslo.db uses oslo.utils.

Changed in ironic:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/112303
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c1fbecf05d621618046428a9efb4ca9a4d2d5225
Submitter: Jenkins
Branch: master

commit c1fbecf05d621618046428a9efb4ca9a4d2d5225
Author: Andrey Kurilin <email address hidden>
Date: Wed Aug 6 16:45:06 2014 +0300

    Use timeutils from one place

    Usage of timeutils from different places (from oslo.db and from ironic)
    can produce errors (for example, during porting oslo.db to using
    oslo.utils, see https://review.openstack.org/#/c/111701/ )

    So we need to remove all imports 'oslo.db.openstack.common.timeutils' and
    don't use `oslo.db.sqlalchemy.models.TimestampMixin`, until ironic and
    oslo.db will use timeutils from one place(from oslo.utils).

    Related-Bug: #1354443

    Change-Id: I53f519570df3351b6acf019d89f67b43d8b637da

Zhongyue Luo (zyluo)
Changed in ironic:
status: Triaged → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → juno-3
status: Fix Committed → Fix Released
Andriy Kurilin (andreykurilin)
Changed in ironic:
assignee: nobody → Andrey Kurilin (akurilin)
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119195

Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-3 → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/119195
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=33a12036d38db085f3ea6c32f053ac4eb4c1ce80
Submitter: Jenkins
Branch: master

commit 33a12036d38db085f3ea6c32f053ac4eb4c1ce80
Author: Andrey Kurilin <email address hidden>
Date: Thu Sep 4 23:16:39 2014 +0300

    Use models.TimestampMixin from oslo.db

    Since `ironic` and `oslo.db` uses `timeutils` from one place,
    we can remove a temporary hack and re-use `TimestampMixin`
    from common db code.

    Change-Id: I48b2ce26484f1283ec65ae4f8dda57d962a8a875
    Closes-Bug: #1354443

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.